Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add spectral lint rule #183

Merged
merged 2 commits into from
Aug 28, 2024
Merged

chore: Add spectral lint rule #183

merged 2 commits into from
Aug 28, 2024

Conversation

blva
Copy link
Collaborator

@blva blva commented Aug 20, 2024 •
edited
Loading

Proposed changes

Add spectral lint to validate custom methods

Example:

INFO: Build completed successfully, 1 total action
Running spectral linter
6.11.1
 - linting /Users/bianca.lisle/workplace/mms/server/openapi/services/openapi-mms.yaml

/<redacted>/openapi-mms.yaml
 1640:69  error  no-slash-before-custom-method  Ensure that paths do not contain a '/' immediately before a custom method (e.g., ':applyItem').  paths./api/atlas/v2/orgs/{orgId}/invoices/{invoiceId}/lineItems/:search

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works

Further comments

andreaangiolillo
andreaangiolillo reviewed Aug 22, 2024
View reviewed changes
.spectral.yaml Outdated Show resolved Hide resolved
@blva blva marked this pull request as ready for review August 22, 2024 09:18
@blva blva requested a review from a team as a code owner August 22, 2024 09:18
Luke-Sanderson
Luke-Sanderson reviewed Aug 22, 2024
View reviewed changes
.spectral.yaml Outdated Show resolved Hide resolved
@blva @Luke-Sanderson
Update .spectral.yaml
f54f8e6 
Co-authored-by: Luke Sanderson <[email protected]>
@andreaangiolillo andreaangiolillo added blocked This PR is blocked. Please, don't merge it. and removed blocked This PR is blocked. Please, don't merge it. labels Aug 28, 2024
andreaangiolillo
andreaangiolillo approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blva blva merged commit 744edaa into main Aug 28, 2024
8 checks passed
@blva blva deleted the spectral-lint branch August 28, 2024 15:25
andreaangiolillo added a commit that referenced this pull request Aug 28, 2024
@andreaangiolillo
Revert "chore: Add spectral lint rule (#183)"
8eb7a6c 
This reverts commit 744edaa.
@andreaangiolillo andreaangiolillo mentioned this pull request Aug 28, 2024
Merged
andreaangiolillo added a commit that referenced this pull request Aug 28, 2024
@andreaangiolillo
fix: Revert "chore: Add spectral lint rule (#183) (#203)
6bd722e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luke-Sanderson Luke-Sanderson Luke-Sanderson left review comments

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blva @andreaangiolillo @Luke-Sanderson